Repository navigation
WebGPU: Make the material buffer helpers ShadingModel methods - #936
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… only the material and key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the helpers used to write the materials buffer out of
writeMaterialsBufferand ontoShadingModel, so subclasses can reuse them when writing their own material structs:getTextureDescriptor( material, key ): the packed "*Map" texture field, previously the localgetTexture. It adds the texture to the shading model'stextureslist, whichupdateMaterialsclears before writing the materials.getField( material, key, default )writeTextureMatrixToArray( material, textureKey, array, offset )writeMaterialsBuffernow returns only{ materialData }, since the textures are tracked on the shading model.🤖 Generated with Claude Code