fix: handle Object member names in Dart, Effect and C# - #3439
Merged
Conversation
Generated-output differences37 files differ — 0 modified, 37 new, 0 deleted |
Generated-output differences36 files differ — 35 modified, 1 new, 0 deleted |
Generated-output differences1 files differ — 0 modified, 1 new, 0 deleted |
* fix(dart): count Unicode code points in string bounds * test(dart): reuse shared Unicode length fixture
* fix(zod): count Unicode code points for string length * test(zod): use shared Unicode length cases
* fix(effect): count Unicode code points for string length * test(effect): use shared Unicode length cases
* fix(javascript): count Unicode code points for string length * test(javascript): use shared Unicode length cases
# Conflicts: # packages/quicktype-core/src/language/Dart/DartRenderer.ts # test/languages.ts
Generated-output differences1 files differ — 0 modified, 1 new, 0 deleted |
…ber-names # Conflicts: # test/languages.ts
Generated-output differences1 files differ — 0 modified, 1 new, 0 deleted |
schani
changed the title
Generated-output differences53 files differ — 41 modified, 12 new, 0 deleted |
schani
changed the title
Generated-output differences53 files differ — 41 modified, 12 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared Object-member names exposed three collisions: Dart properties override incompatible
Objectmembers; Effect’s read-onlytoStringprevents decoding that property; C# records namedToStringconflict with their synthesized method. Reserve the conflicting Dart properties and C# record names, and permit the JSON property on affected Effect subclasses.Adds
hashCode,runtimeType,toStringandnoSuchMethodto the existing sharedkeywords.json. Removes the Dart-only schema cases. No new fixture or keyword exclusion.Validation: baseline Dart compilation, Effect decoding and C# record compilation fail; fixed cases pass. All 145 Effect JSON/schema fixtures pass. Explicit Effect decode/encode, constructor validation, invalid-type rejection and generated TypeScript checks pass. The combined keyword sample passes all three C# variants and the available language fixtures. Build, Biome and full CI pass.
Production lines added/removed per fix: Dart 8, Effect 7, C# 2.