fix(objective-c): escape control characters in string literals - #3447
Merged
Conversation
Generated-output differences2 files differ — 0 modified, 2 new, 0 deleted |
Generated-output differences86 files differ — 81 modified, 5 new, 0 deleted |
Generated-output differences131 files differ — 81 modified, 50 new, 0 deleted |
schani
enabled auto-merge (squash)
September 5, 2026 17:47
Generated-output differences220 files differ — 87 modified, 133 new, 0 deleted |
Generated-output differences232 files differ — 87 modified, 145 new, 0 deleted |
Generated-output differences1259 files differ — 1090 modified, 169 new, 0 deleted |
Generated-output differences1258 files differ — 1090 modified, 168 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective-C literals rejected C0/C1 control escapes. Encode them as UTF-8 octal escapes while preserving literal backslashes.
Adds an ordinary JSON sample with repeated C0/C1 strings that infer an enum and a separate literal-backslash string. The existing Objective-C fixture compiles and round-trips it.
blns-object.jsonremains skipped because Foundation drops BOM object keys.Validation: baseline compilation rejects the control literals; Objective-C, Go, PHP, and Zod fixture round-trips pass with the fix. The cJSON fixture driver also round-trips without Valgrind. Kotlin/Jackson and Klaxon skip this sample because their enum serializers emit unescaped control characters. Core build and Biome pass. Production change: 14 added/removed lines.