Preserve prototype-named keys in Zod maps - #3522
Open
schani wants to merge 3 commits into
Open
Conversation
Generated-output differences47 files differ — 47 modified, 0 new, 0 deleted |
Member
Author
|
No comments here either! |
Member
Author
|
Added API tests in |
Generated-output differences47 files differ — 47 modified, 0 new, 0 deleted |
Generated-output differences47 files differ — 47 modified, 0 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z.recordreconstructs decoded maps through plain-object assignment, which drops an own__proto__key. Decode validated entry tuples withObject.fromEntries, preserving prototype-named keys, value transforms, and inferred record types.The API test executes generated Zod code with a null-prototype input, verifies the output has an ordinary prototype and an own
__proto__descriptor, rejects Date/Map/Set inputs likez.record, and typechecks inferred numeric values. The shared JSON regression lands in downstream #3519.Production diff: 9 additions, 1 deletion.
Validation: build; lint; API unit; TypeScript Zod fixtures 145/145.