Repository navigation
Add data-driven JSON validation fixtures - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<name>.schema.json,<name>.pass.<case-id>.json, and<name>.fail.<case-id>.jsonnpm run test:fixturesWhy
Most validation regressions only need a JSON Schema plus accepted and rejected JSON values. Keeping those cases as data removes repetitive test code and makes new coverage possible by adding files alone.
Validation
vitest run tests/json-fixtures.test.ts— 661 passedvitest run --coverage --exclude '.claude/**'— 1,962 passed, 104 skipped; 100% statements, lines, and functionsnpm run build— passed