Repository navigation
docker image for arm64 - #313
Conversation
froozeify
left a comment
There was a problem hiding this comment.
Hello, prod image are already build for arm : https://github.com/glpi-project/docker-images/blob/main/.github/workflows/glpi.yml
Could you take inspiration on the build logic (build matrix, merge manifest). That logic was chosen for build time optimization.
|
@froozeify Hello! I tried to mirror the build logic from |
|
Hello, I see some missing items before we could merge it:
|
* linux/arm64
* added docker metadata
* updated Build and push by digest
|
The comments were addressed |
|
Once merged, I will created a dedicated PR to reduce the duplication with matrix generation to have only one in this file to maintain |
| tags: "ghcr.io/glpi-project/glpi-development-env:${{ matrix.php-version }}${{ matrix.latest == 'true' && ',ghcr.io/glpi-project/glpi-development-env:latest' || '' }}" | ||
| sbom: ${{ env.PUSH == 'true' }} | ||
| provenance: ${{ env.PUSH == 'true' && 'mode=max' || 'false' }} | ||
| outputs: "type=image,name=${{ env.GHCR_IMAGE }},push-by-digest=true,name-canonical=true,push=${{ env.PUSH }}" |
There was a problem hiding this comment.
Are you sure about push=${{ env.PUSH }}? Will it be rendered as 'true'|'false', 1|0, or maybe an 1|(empty string)?
There was a problem hiding this comment.
Line 27, we get the PUSH env.PUSH declaration. ${{ github.ref == 'refs/heads/main' && github.repository == 'glpi-project/docker-images' }}
It's a condition so it will output a bool.
Github convert it to string : https://docs.github.com/en/actions/reference/workflows-and-actions/expressions
There was a problem hiding this comment.
empty will also be returned as false string
No description provided.