Conversation
|
Hi @valvin1! Thanks for creating this PR. I'd love to merge this, could you make the following changes:
|
| @@ -63,6 +63,9 @@ function Slideshow (events, dom, options, callback) { | |||
| if (options.sourceUrl) { | |||
| loadFromUrl(options.sourceUrl, callback); | |||
There was a problem hiding this comment.
Refactor loadFromUrls and use it here -- (that way we can remove the loadFromUrl function and only have one.
peterj
left a comment
There was a problem hiding this comment.
Check the comments - refactor loadFromUrls + review/add tests if needed to cover the new scenario.
|
@valvin1 any progress here? this feature is really cool and would like to see it :) |
|
Hello @peterj I decided to try and help take @valvin1's great idea across the finish line here. I have the work in my fork here. Would it work best to just create a new PR from there? Or should I try and pull it into his original PR branch? Thanks |
As mentionend in #560 this feature allowes to load several sources using option
sourceUrlsinstead ofsourceUrl