Skip to content

fix(middleware): accept quoted charset in Content-Type #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sonnemusk wants to merge 2 commits into from
Closed

fix(middleware): accept quoted charset in Content-Type #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff27c6
fix(middleware): accept quoted charset in Content-Type
sonnemusk Jul 22, 2026
5af0aa8
test(middleware): cover quoted Content-Type charset
sonnemusk Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions middleware/content_charset.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ func contentEncoding(ce string, charsets ...string) bool {
_, ce = split(strings.ToLower(ce), ";")
_, ce = split(ce, "charset=")
ce, _ = split(ce, ";")
// Clients often quote the charset parameter: charset="utf-8"
ce = strings.Trim(ce, `"'`)
return slices.Contains(charsets, ce)
}

Expand Down
17 changes: 17 additions & 0 deletions middleware/content_charset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package middleware

import (
"strings"
"net/http"
"net/http/httptest"
"testing"
Expand Down Expand Up @@ -125,3 +126,19 @@ func TestContentEncoding(t *testing.T) {
t.Error("Want true, got false")
}
}

func TestContentCharsetQuoted(t *testing.T) {
t.Parallel()
mw := ContentCharset("utf-8")
body := strings.NewReader(`{}`)
r := httptest.NewRequest("POST", "/", body)
r.Header.Set("Content-Type", `application/json; charset="utf-8"`)
w := httptest.NewRecorder()
router := chi.NewRouter()
router.Use(mw)
router.Post("/", func(w http.ResponseWriter, r *http.Request) {})
router.ServeHTTP(w, r)
if w.Code != 200 {
t.Fatalf("got %d want 200 for quoted charset", w.Code)
}
}