Repository navigation
fix(middleware): initialize compression headers before flushing - #1199
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Co-Authored-By: OpenAI GPT-6.1-Sol <noreply@openai.com> Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Flush()before the first write commits the underlying response headers without lettingCompresschoose its encoding. A subsequent write can then produce gzip or deflate bytes without aContent-Encodingheader.Initialize the existing header path before flushing, just as
Writealready does. The regression test uses a real HTTP server and checks decoded body content, repeated flushes, explicit status codes, identity encoding and non-compressible content types.Verified the regression fails against the original implementation, then ran
make test(the full race suite),go vet ./...and goimports checks successfully on Go 1.26.4/macOS. The other Go versions and Windows CI matrix were not run locally.Implemented and verified with AI assistance through Hermes Agent.