Repository navigation
fix(middleware): apply PathRewrite to existing routing paths - #1201
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com> Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathRewrite updates URL.Path, but mounted routers and preceding middleware such as URLFormat can already have set RoutePath. Routing then continues with the unchanged path and rewritten requests return 404.
Rewrite an existing RoutePath independently while preserving the original first replacement in URL.Path. The routing path remains relative to its mount point, and the godoc explains where full-path rewrites belong. Regression tests exercise mounted and nested routers, encoded parameters, repeated matches, URLFormat composition, and full-path middleware placement.
The regressions fail against the original implementation.
go test -race -count=1 ./...,go vet ./..., and goimports pass locally on Go 1.26.4/macOS arm64; the other Go versions and operating systems in CI have not been run locally.