Repository navigation
fix(tree): reject duplicate param keys before insert - #1207
Open
therealgofman wants to merge 1 commit into
Open
therealgofman wants to merge 1 commit into
therealgofman wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
InsertRoutepanics on a duplicate param key (chi: routing pattern '…' contains duplicate param key, '…'). That panic is intended.patParamKeysruns fromsetEndpoint, afteraddChildhas already written nodes. If the caller recovers and then serves on the same mux,findRoutenever returns.Seen with a recovered
Getof about 25 empty{}segments plus a static tail, thenServeHTTPon"/{.This is not the self-mount loop (
Mount("/", r)/ #843 / #663).Same symptom, different entry.
Repro (v5.3.2)
Fix
Call patParamKeys(pattern) at the start of InsertRoute, before any tree write. The panic is unchanged. The tree stays empty. After recover, ServeHTTP is 404. A later valid Get still works.