feat(manage): add SetGrantTypeTokenCfg for custom grant type support#295
Open
SxxSolar wants to merge 1 commit into
Open
feat(manage): add SetGrantTypeTokenCfg for custom grant type support#295SxxSolar wants to merge 1 commit into
SxxSolar wants to merge 1 commit into
Conversation
The Manager struct has a private gtcfg field (map[oauth2.GrantType]*Config), but only provides configuration methods for the 4 standard OAuth2 grant types: - SetAuthorizeCodeTokenCfg - SetImplicitTokenCfg - SetPasswordTokenCfg - SetClientTokenCfg This prevents users from configuring custom grant types. This commit adds a generic SetGrantTypeTokenCfg(gt GrantType, cfg *Config) method that allows users to configure token settings for any grant type, including custom ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetGrantTypeTokenCfg(gt oauth2.GrantType, cfg *Config)method toManagerstruct to enable custom grant type configurationProblem
The
Managerstruct has a privategtcfgfield (map[oauth2.GrantType]*Config), but only provides configuration methods for the 4 standard OAuth2 grant types:SetAuthorizeCodeTokenCfgSetImplicitTokenCfgSetPasswordTokenCfgSetClientTokenCfgThis design prevents users from configuring custom grant types, which is a common requirement in OAuth2 implementations (e.g.,
device_code,urn:ietf:params:oauth:grant-type:jwt-bearer, etc.).Solution
Add a generic
SetGrantTypeTokenCfg(gt oauth2.GrantType, cfg *Config)method that allows users to configure token settings for any grant type, including custom ones.Usage Example