fix(deps): bump dompurify 3.4.1 → 3.4.10 (resolves 8 security alerts)#386
Merged
Conversation
Dependabot's client npm group (#383) bumped 41 packages but left dompurify at 3.4.1, leaving 5 open dompurify alerts (2 med IN_PLACE/clobber, lows for SAFE_FOR_TEMPLATES bypass + Trusted-Types clearConfig) plus transitive babel/ js-yaml. dompurify isn't in the dependabot ignore list — it just wasn't grouped. Bump the direct dep AND the overrides pin (so transitive consumers like monaco-editor also get the patched version); lock resolves to 3.4.11, above all the alert fix versions (3.4.6-3.4.9). The one remaining dompurify alert (IN_PLACE nodeName, no patch available) does not apply — SafeHTMLRenderer sanitizes in WHOLE_DOCUMENT mode, not IN_PLACE. The 3.4.10 happy-dom incompatibility that bit us earlier is already mitigated: SafeHTMLRenderer's test runs under jsdom. Verified: full client suite 198 files / 1441 tests pass, SafeHTMLRenderer 4/4, tsc clean, npm ci exits 0 under both node:20 (test runner) and node:26 (image build). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's client npm group (#383) bumped 41 packages but left dompurify at 3.4.1 (it's not in the ignore list — just wasn't grouped), leaving 5 open dompurify Dependabot alerts + transitive babel/js-yaml ones.
Change
dompurify^3.4.1→^3.4.10in bothdependenciesandoverrides(the override ensures transitive consumers like monaco-editor also get the patched version). Lock resolves to 3.4.11 — above all alert fix versions (3.4.6–3.4.9).Alerts resolved
clearConfigsurvival)IN_PLACEnodeName, no patch available) does not apply — SafeHTMLRenderer sanitizes inWHOLE_DOCUMENTmode, notIN_PLACE.On the 3.4.10 × happy-dom history
The incompatibility that bit us earlier is already mitigated — SafeHTMLRenderer's test runs under
jsdom(per-file env), so the newer dompurify works.Verification
npm ciexits 0 under both node:20 (test runner) and node:26 (image build)🤖 Generated with Claude Code