Add pull_request trigger and all-tests-passed aggregator job to CI workflow - #232
Merged
Merged
Conversation
…rkflow A push-only trigger never runs against a fork PR's head commit, which would block external contributions once a check from this workflow is required in branch protection. The test_library job is also a matrix over 4 PHP versions, producing one check per entry - brittle to require individually since the list shifts whenever a PHP version is added or dropped. The aggregator job depends on the whole matrix so branch protection can require a single stable check name.
jcardozagc
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requesttrigger alongside the existingpushtrigger so tests run against fork PRs, not just pushes to the repo.pushtrigger tomasteronly.all-tests-passedjob that depends on the wholetest_librarymatrix (PHP 8.2-8.5) and fails if any entry didn't succeed.Why
Part of IX-2323: setting up required status checks across GoCardless's public client library repos so we can safely enable auto-merge. A push-only trigger never runs against a fork PR's head commit, and the
test_librarymatrix produces one check per PHP version - brittle to require individually since the list shifts whenever a version is added or dropped.all-tests-passedgives branch protection a single stable, fork-compatible check name to require.Test plan
all-tests-passedappears and passes on this PR