Skip to content

Internationalize the Features and Download pages - #1026

Draft
Calinou wants to merge 1 commit into
godotengine:masterfrom
Calinou:i18n-features-download
Draft

Calinou wants to merge 1 commit into
godotengine:masterfrom
Calinou:i18n-features-download

Conversation

@Calinou

@Calinou Calinou commented Feb 28, 2025 •

Copy link
Copy Markdown
Member

This adds a French translation for both pages as well.

Preview

image

TODO

  • Make translations visible on the Download page by fixing URLs (/fr/download/linux is not being generated, only /fr/download is).
    • I've tried to add localize: ["en", "fr"] to collections/_download/linux.md to no avail.
  • Change links to pages to use localized variants according to the current page language.
  • Make the language dropdown preserve the page you're currently looking at, instead of redirecting you to the homepage. window.location.pathname is supposed to do this, but it doesn't work after you use it once.

This adds a French translation for both pages as well.

TODO:

- Make translations visible on the Download page by fixing URLs
  (`/fr/download/linux` is not being generated, only `/fr/download` is).
- Change links to pages to use localized variants according to the current
  page language.
- Make the language dropdown preserve the page you're currently looking at,
  instead of redirecting you to the homepage. `window.location.pathname`
  is supposed to do this, but it doesn't work after you use it once.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant