UI incorrectly displayed - #1386
Open
midaksh wants to merge 2 commits into
Open
Conversation
Author
|
Hey @Calinou, is there any feedback for this, or anything else that needs to be done? |
Author
|
Hey @Calinou if there are some issues here, I can tak this to a draft PR else it is open for review let me know if everything is fine. |
Author
|
Hey @Calinou should I close the PR ? |
Collaborator
|
I'm not @Calinou, but can you show some before images for Russian and Ukrainian, to better show what you've changed? |
Author
|
Hi @Calinou, below are the attached images for the before comparision, and the output result for the same is already in the above description. As you can clearly see the menu/header bar text is not aligned as mentioned in #1237 This is a fix for that, let me know if there is something else that you need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #1237
The navbar layout broke when switching to languages with longer words (e.g. Ukrainian, Russian). Nav links wrapped to a second line and the Donate button was clipped or hidden.
Changes:
assets/css/header.csswhite-space: nowrapon all nav links, prevents any translated text from wrapping inside a link, regardless of languageclamp()on font-size and padding — font and spacing scale down proportionally on tighter viewports instead of staying fixed.fit-contentpill width — the navbar pill now sizes to its content and stays centered withmargin-inline: auto, so it expands equally on both sides instead of overflowing to the right.Below are some images: