Repository navigation
feat(pkg): add go-import page for traces/exporters/gcp - #229
Merged
Merged
Conversation
gofr.dev/pkg/gofr/traces/exporters/gcp is its own Go module (the keyless Google Cloud trace exporter shipped in gofr v1.62.0), but the vanity server has no route for it, so go get cannot resolve the module path. Same shape as the metrics/exporters/gcp page (#226): a layout carrying the go-import and go-source metadata, byte-identical to the existing layouts, and a PkgRedirect page so the route returns 200. docsPath points at the production tracing guide, which documents TRACE_EXPORTER=gcp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the vanity-import route for
gofr.dev/pkg/gofr/traces/exporters/gcp, the keyless Google Cloud trace exporter that shipped in gofr v1.62.0.Why
It is its own Go module, but gofr.dev has no route for it, so
go getcannot resolve the module path:All 27 other gofr submodules already resolve. I checked every
go.modunderpkg/at v1.62.0 against the live site; this is the only one missing.Approach
Identical to #226 (metrics/exporters/gcp):
layout.jsx: thego-import/go-sourcemetadata, byte-identical tometrics/exporters/gcp/layout.jsx(checked withcmp).page.jsx: aPkgRedirectpage, so the route renders and returns 200.docsPathpoints at/docs/guides/production-tracing, whose "Google Cloud (keyless)" section documentsTRACE_EXPORTER=gcp.Verification
next devon this branch:/pkg/gofr/traces/exporters/gcp?go-get=1gofr.dev git https://github.com/gofr-dev/gofr/pkg/gofr/metrics/exporters/gcp?go-get=1(control)Related
go.mod. It still had areplaceand required gofr v1.60.1. After #4409 merges,pkg/gofr/traces/exporters/gcp/v0.1.0gets tagged. Both this route and that tag are needed beforego getworks.