Add optional TypeScript runtime support - #124
Open
noise64 wants to merge 7 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
noise64
commented
Aug 6, 2026
|
|
||
| sqlite = ["dep:rusqlite"] | ||
| timezone = ["dep:chrono-tz"] | ||
| typescript-runtime = [ |
Contributor
Author
There was a problem hiding this comment.
Let's follow the grouping style already used here, and for the swc deps
noise64
commented
Aug 6, 2026
| # This matches the validation the Preview 2 path gets from `golem-wasi-http` (which re-exports the | ||
| # same `http` crate) without depending on `golem-wasi-http` itself. | ||
| http = { version = "1", optional = true } | ||
| swc_common = { version = "24", optional = true } |
Contributor
Author
There was a problem hiding this comment.
Are these okay to be not pinned? What are the guarantees defined by swc project versioning
noise64
commented
Aug 6, 2026
| const MAX_OUTPUT_BYTES: usize = 64 * 1024 * 1024; | ||
| // Native SWC work cannot be interrupted while Rust is executing. Keep inline | ||
| // jobs tightly bounded; worst-case sibling-job latency is tracked by GOL-347. | ||
| const MAX_SOURCE_BYTES: usize = 256 * 1024; |
Contributor
Author
There was a problem hiding this comment.
Let's revisit if this is reasonable / needed constraint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module.stripTypeScriptTypes, TypeScript module loading, feature reporting, and node_modules rejection behaviorwasm-rquickjs:executionjobs across P2 and P3Node compatibility
3228/4425 (72.9%)→3236/4425 (73.1%)3228/5750 (56.1%)→3236/5750 (56.3%)module:120 passing / 34 gaps→129 passing / 25 gapsutil:89 passing / 8 gaps→88 passing / 9 gaps, honestly classifying transformed TypeScript call-site source-map remapping as unsupportedtest-module-strip-typessubtests; remaining TypeScript CLI fixtures retain preciseprocess.execPath/flag-emulation deferralsValidation
stripTypeScriptTypescompatibility casestest-util-getcallsitesverification: 12 passed, 1 explicit source-map gap