Fix EXC_BAD_ACCESS in GDTCORLogAssert when path contains % characters - #173
Merged
Conversation
Member
Author
|
CI failures look like flakes #172 |
ncooke3
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May fix firebase/firebase-ios-sdk#16455. If not, this fix still makes sense.
When a user's project path contained a % character, the compile-time absolute path FILE macro embedded into the binary also contained a % character. When an assertion triggered in GDTCORPlatform.m, the path was injected unsafely into a format string and passed to NSLogv, causing an EXC_BAD_ACCESS null pointer dereference.
This PR fixes the issue by pre-formatting the variadic arguments into a message string and safely supplying the formatting parameters directly to NSLog.