Skip to content

Minor cleanup of FileSaver #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jtdavis777 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor cleanup of FileSaver #8863

jtdavis777 wants to merge 2 commits into from
+51 −39

Conversation

@jtdavis777
Copy link
Collaborator

@jtdavis777 jtdavis777 commented Dec 18, 2025

After discussion with @dbaileychess, I have moved the concrete instance definitions of FileSaver into the cpp files which define them.

@github-actions github-actions bot added c++ codegen Involving generating code from schema labels Dec 18, 2025
@jtdavis777 jtdavis777 added the ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner label Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aardappel aardappel Awaiting requested review from aardappel

@dbaileychess dbaileychess Awaiting requested review from dbaileychess dbaileychess is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

c++ codegen Involving generating code from schema ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jtdavis777