Skip to content

Fix two argument-handling bugs in install and update - #218

Open
jm2 wants to merge 1 commit into
google:masterfrom
jm2:cli-fixes
Open

jm2 wants to merge 1 commit into
google:masterfrom
jm2:cli-fixes

Conversation

@jm2

@jm2 jm2 commented Oct 7, 2026

Copy link
Copy Markdown
Member
  • install checked flag.Args(), the global command line, instead of the subcommand's flags.Args(). The global args include the subcommand name, so allFileGoos was always false. As a result, installing only local .goo files still required configured repos.
  • update logged a WhatRepo failure but then called install.FromRepo with an empty repo. It now marks the run as failed and skips that package.

install checked flag.Args(), the global command line, instead of the
subcommand's flags.Args(). The global args include the subcommand name,
so allFileGoos was always false and installing only local .goo files
still required configured repos.

update logged a WhatRepo failure but then called install.FromRepo with
an empty repo. It now marks the run failed and skips the package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant