Angular Configuration Simplification + Localization File Updates

[rfontanarosa]

towards #2422

closes #2306

[gemini-code-assist]

Summary of Changes

Hello @rfontanarosa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve the local development experience by resolving issues related to full page refreshes. It achieves this by simplifying the Angular build configurations, specifically by removing redundant or problematic localized development setups. Additionally, it includes minor but important corrections to localization files, ensuring accurate language identification within the application's internationalization setup.

Highlights

• Angular Configuration Simplification: Removed multiple development-xx localization configurations from angular.json to streamline the build process and address local development issues.
• Localization File Corrections: Corrected the locale field in messages.lo.json and messages.th.json from "en" to their respective language codes ("lo" and "th").

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• web/angular.json
  • Removed development-en, development-es, development-fr, development-lo, development-pt, development-th, and development-vi configurations from the architect.build.configurations section.
  • Removed development-es, development-fr, development-lo, development-pt, development-th, and development-vi configurations from the architect.serve.configurations section.
• web/src/locale/messages.lo.json
  • Changed the locale property value from "en" to "lo".
• web/src/locale/messages.th.json
  • Changed the locale property value from "en" to "th".

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a local development issue with page refreshes by removing locale-specific development configurations from angular.json. It also corrects misconfigured locale identifiers in the messages.lo.json and messages.th.json files. While removing the Angular configurations may fix the immediate problem, it also removes the ability to test localization with the development server, which is a significant drawback for the development workflow. I have left a comment suggesting an alternative approach that would preserve this functionality. The corrections to the locale files are appropriate.

I am having trouble creating individual review comments. Click here to see my feedback.

web/angular.json (119-139)

Removing these locale-specific development configurations disables the ability to test internationalization (i18n) using ng serve. This represents a significant regression in the development workflow for anyone needing to verify translations. While it may resolve the page refresh issue, a better approach would be to investigate the root cause of the refresh failure. This kind of issue is often solvable by correctly configuring the development server to handle SPA routing for localized paths, without needing to remove this important development-time feature.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.13%. Comparing base (5bee824) to head (ad0f8f0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2433   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files         111      111           
  Lines        2748     2748           
  Branches      408      408           
=======================================
  Hits         1625     1625           
  Misses       1065     1065           
  Partials       58       58           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.