Merged
Conversation
If there's a mix of mappings and singular elements, the mappings will (maybe) be quoted correctly but the singular elements won't be, which can result in a YAML flow sequence that's not valid YAML.
KatrinaHoffert
approved these changes
Mar 24, 2026
Member
KatrinaHoffert
left a comment
KatrinaHoffert
left a comment
There was a problem hiding this comment.
takeYAMLSeriously: "no"
auto-merge was automatically disabled
March 24, 2026 14:27
Pull Request is not mergeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's a mix of mappings and singular elements, the mappings will
(maybe) be quoted correctly but the singular elements won't be, which
can result in a a different YAML flow sequence or even invalid YAML if the singular element has the right special characters.
e.g. Before the changes to options.go, the test was generating a different flow sequence with 3 elements instead of 2:
by_regex=[foo, bar, \"\\\\b(\\\\d{2})/(\\\\d{2})/(\\\\d{4})\\\\b\": \"${3}-${1}-${2}\"]"We now generate strings that include mapping braces (
{and}, e.g.by_regex=['foo, bar', {'\b(\d{2})/(\d{2})/(\d{4})\b': '${3}-${1}-${2}'}]). That's less than ideal, but it's still better than generating invalid YAML. I don't see any options in the YAML library to turn those braces off :/ https://pkg.go.dev/gopkg.in/yaml.v3