Skip to content

Allow maintainers to re-trigger lint validation via a recheck label - #3530

Merged
copybara-service[bot] merged 2 commits into
google:mainfrom
mridul-sahu:lint-recheck-label
Aug 11, 2026
Merged

Allow maintainers to re-trigger lint validation via a recheck label#3530
copybara-service[bot] merged 2 commits into
google:mainfrom
mridul-sahu:lint-recheck-label

Conversation

@mridul-sahu

Copy link
Copy Markdown
Collaborator

Description

Fork PRs from outside collaborators need a maintainer to approve their workflow runs, and GitHub deletes runs that sit awaiting approval for more than 30 days. Once that happens the PR has no way to run Code Formatting & Lint Validation again, so the Auto Label PR workflow never fires and the PR can never receive pull ready (see #3414 and #3458, both of which aged out of their approval window and needed manual labeling).

This adds a labeled trigger to the lint workflow, gated to a single label: applying recheck to a PR fires a fresh validation run on the PR delta, with the labeling maintainer as the triggering actor. The run stays in the unprivileged pull_request context (read-only token, no secrets), and every existing trigger path is unchanged. Auto Label PR removes recheck after it processes the result, so the label can be re-applied whenever another run is needed.

Requires the recheck label to exist in the repo (create once under Issues → Labels).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (alters existing behavior or a public API)
  • Docs / tests / internal tooling (no user-facing behavior change)

Checklist

  • I have read the contribution guidelines.
  • Tests cover this change and pass locally.
  • Public APIs and non-trivial functions are documented.
  • If this change is user-facing, I have updated CHANGELOG.md under the [Unreleased] section (or the relevant checkpoint/ / export/ changelog).

@github-actions github-actions Bot added the pull ready Ready to be pulled from GitHub into Google label Aug 11, 2026
Workflow runs awaiting approval on fork PRs are deleted after 30 days;
after that such PRs can no longer be validated or auto-labeled pull
ready without a new pull_request event. Applying the recheck label
fires a fresh validation run with the labeling maintainer as the
triggering actor, and the Auto Label PR workflow removes the label
after processing the result so it can be re-applied for another run.
Pin actions to commit SHAs, disable credential persistence on checkout,
and annotate the API-only workflow_run trigger as an accepted pattern.
@copybara-service
copybara-service Bot merged commit eaae692 into google:main Aug 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pull ready Ready to be pulled from GitHub into Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant