net-test: packetdrill: fix the icmp echo bytes#94
Open
WeiRG wants to merge 1 commit intogoogle:masterfrom
Open
net-test: packetdrill: fix the icmp echo bytes#94WeiRG wants to merge 1 commit intogoogle:masterfrom
WeiRG wants to merge 1 commit intogoogle:masterfrom
Conversation
When a icmp packet use opt_icmp_echoed option, the payload_bytes which provided by UDP, is not add in icmp_bytes yet, this would make paylaod error when packet verify. For example: in script the packet event like this: ... +0 > icmp unreachable port_unreachable[udp(20)] It will result in the following errors: live packet payload: expected 28 bytes vs actual 48 bytes The packet_payload_len function is not contains the payload_bytes. Add the payload_bytes in echoed_bytes to fix this error. Signed-off-by: Rongguang Wei <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ammarqubaty2013-blip
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a icmp packet use opt_icmp_echoed option, the payload_bytes which provided by UDP, is not add
in icmp_bytes yet, this would make paylaod error when packet verify. For example:
in script the packet event like this:
...
+0 > icmp unreachable port_unreachable[udp(20)]
It will result in the following errors:
live packet payload: expected 28 bytes vs actual 48 bytes
The packet_payload_len function is not contains the payload_bytes. Add the payload_bytes in echoed_bytes to fix this error.