Add sample labels flag to perf_to_profile#197
Add sample labels flag to perf_to_profile#197mmcloughlin wants to merge 1 commit intogoogle:masterfrom
Conversation
Add a -l option that accepts a comma-separated list of sample label names (pid, tid, comm, etc.) to include in the output profile. This exposes the existing SampleLabels enum through the CLI, which was previously only accessible programmatically. Fixes google#104
|
@mmcloughlin Sorry, we don't accept contributions to this repo right now, it's a one-way mirror. |
Oh, I missed that. It's a bit confusing because there are merged PRs on this repository. Would you be able to implement this feature internally? |
Those are mirrored. I think they look differently because when multiple changes are mirrored at once the PR name becomes more generic.
In theory yes, in practice I don't know when exactly this will happen. Because priorities, sorry. I agree it's a useful change - we have a version of it internally, which is unfortunately a distinct piece of code because historical reasons. |
2 participants
Add a -l option to configure sample labels via the
perf_to_profileCLI tool.Fixes #104