fix(web): detect secure context for subtle crypto#262
Open
HamdaanAliQuatil wants to merge 4 commits intomasterfrom
Open
fix(web): detect secure context for subtle crypto#262HamdaanAliQuatil wants to merge 4 commits intomasterfrom
HamdaanAliQuatil wants to merge 4 commits intomasterfrom
Conversation
jonasfj
approved these changes
Apr 24, 2026
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
Minor improvement, but let's consider putting the logic into the subtle getter
Collaborator
Author
|
Added targeted coverage for the new The getter design stays the same; I extracted the branch selection into a testable helper and added tests for the two negative cases. Coveralls increased by 0.02%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #159