Conversation
westarle
force-pushed
the
feat/t3-traces-go
branch
from
April 20, 2026 21:48
b1ae979 to
b282732
Compare
westarle
force-pushed
the
feat/t3-traces-go
branch
from
April 20, 2026 21:53
b282732 to
8c4149c
Compare
bhshkh
force-pushed
the
feat/t3-traces-go
branch
from
June 23, 2026 06:54
559ef22 to
04ddc3d
Compare
…path Eliminates an unnecessary heap allocation on the critical hot path of every API call. Synchronous, in-memory metric recording (`histogram.Record()`) does not perform I/O and is completely unaffected by context cancellation. Furthermore, trace context values (active spans) remain fully extractable via `trace.SpanContextFromContext(ctx)` even if the context's `Done()` channel has been closed. Thus, wrapping the context with `WithoutCancel` is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements T3 spans (Client Request) in gax.Invoke when the TRACING feature flag is enabled.
Key changes:
Testing: