Skip to content

feat: API regeneration: 20260520T070127Z#15622

Merged
jskeet merged 1 commit into
mainfrom
librarian-regen-20260520T070127Z
May 20, 2026
Merged

feat: API regeneration: 20260520T070127Z#15622
jskeet merged 1 commit into
mainfrom
librarian-regen-20260520T070127Z

Conversation

@google-cloud-sdk-librarian-dotnet-robot
Copy link
Copy Markdown
Collaborator

@google-cloud-sdk-librarian-dotnet-robot google-cloud-sdk-librarian-dotnet-robot commented May 20, 2026

Changes in this PR

  • Generated Google.Cloud.DatabaseCenter.V1Beta

@google-cloud-sdk-librarian-dotnet-robot
regen: Regenerate Google.Cloud.DatabaseCenter.V1Beta at API commit d4…
0562ecb 
…c5fdd

feat: add a AggregateQueryStats  API


PiperOrigin-RevId: 917888205
Source-Link: googleapis/googleapis@d4c5fdd
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented May 20, 2026

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Pull request diff results
Finding changes in Google.Cloud.DatabaseCenter.V1Beta...
Comparing old and new versions (by source)
Minor changes:
Class 'AggregateQueryStatsRequest' added.
Class 'AggregateQueryStatsResponse' added.
Class 'DatabaseCenter.DatabaseCenterBase'; method 'Task AggregateQueryStats(AggregateQueryStatsRequest request, ServerCallContext context)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AggregateQueryStatsResponse AggregateQueryStats(AggregateQueryStatsRequest request, CallOptions options)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AggregateQueryStatsResponse AggregateQueryStats(AggregateQueryStatsRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AsyncUnaryCall AggregateQueryStatsAsync(AggregateQueryStatsRequest request, CallOptions options)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AsyncUnaryCall AggregateQueryStatsAsync(AggregateQueryStatsRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'DatabaseCenterClient'; method 'PagedAsyncEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStatsAsync(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterClient'; method 'PagedEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStats(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterClientImpl'; method 'PagedAsyncEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStatsAsync(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterClientImpl'; method 'PagedEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStats(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterSettings'; property 'CallSettings AggregateQueryStatsSettings { get; set; }' added.
Class 'QueryMetrics' added.
Class 'QueryMetrics.Types' added.
Enum 'QueryMetrics.Types.MetricsWindow' added.
Class 'QueryStats' added.
Class 'QueryStatsInfo' added.
Class 'ResourceId' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.DatabaseCenter.V1Beta version 1.0.0-beta07
Differences from 1.0.0-beta07
Minor changes:
Class 'AggregateQueryStatsRequest' added.
Class 'AggregateQueryStatsResponse' added.
Class 'DatabaseCenter.DatabaseCenterBase'; method 'Task AggregateQueryStats(AggregateQueryStatsRequest request, ServerCallContext context)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AggregateQueryStatsResponse AggregateQueryStats(AggregateQueryStatsRequest request, CallOptions options)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AggregateQueryStatsResponse AggregateQueryStats(AggregateQueryStatsRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AsyncUnaryCall AggregateQueryStatsAsync(AggregateQueryStatsRequest request, CallOptions options)' added.
Class 'DatabaseCenter.DatabaseCenterClient'; method 'AsyncUnaryCall AggregateQueryStatsAsync(AggregateQueryStatsRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'DatabaseCenterClient'; method 'PagedAsyncEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStatsAsync(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterClient'; method 'PagedEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStats(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterClientImpl'; method 'PagedAsyncEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStatsAsync(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterClientImpl'; method 'PagedEnumerable<AggregateQueryStatsResponse, QueryStatsInfo> AggregateQueryStats(AggregateQueryStatsRequest request, CallSettings callSettings = null)' added.
Class 'DatabaseCenterSettings'; property 'CallSettings AggregateQueryStatsSettings { get; set; }' added.
Class 'QueryMetrics' added.
Class 'QueryMetrics.Types' added.
Enum 'QueryMetrics.Types.MetricsWindow' added.
Class 'QueryStats' added.
Class 'QueryStatsInfo' added.
Class 'ResourceId' added.

Diff level: Minor

Finished comparisons for Google.Cloud.DatabaseCenter.V1Beta

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the AggregateQueryStats and AggregateQueryStatsAsync methods to the DatabaseCenterClient, providing database resource query execution statistics. The changes include the necessary client implementation, gRPC service updates, and generated code snippets. Feedback was provided regarding a potential naming mismatch in ServiceResourceNames.g.cs, where the partial class QueryStats should likely be renamed to QueryStatsInfo to align with the message type returned by the new API methods.

Comment thread ...gle.Cloud.DatabaseCenter.V1Beta/Google.Cloud.DatabaseCenter.V1Beta/ServiceResourceNames.g.cs

namespace Google.Cloud.DatabaseCenter.V1Beta
{
public partial class QueryStats
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The partial class is named QueryStats, but the AggregateQueryStats method returns a sequence of QueryStatsInfo objects (as seen in DatabaseCenterClient.g.cs and snippet_metadata_google.cloud.databasecenter.v1beta.json). If the ResourceTypeAsResourceName property was intended to be available on the items returned by AggregateQueryStats, this partial class should be named QueryStatsInfo to match the message type.

    public partial class QueryStatsInfo

@jskeet jskeet merged commit 7b1e369 into main May 20, 2026
14 checks passed
@jskeet jskeet deleted the librarian-regen-20260520T070127Z branch May 20, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jskeet jskeet jskeet approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@google-cloud-sdk-librarian-dotnet-robot @jskeet