feat(dql/maps): add runtime query evaluation#2707
Draft
aofei wants to merge 3 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2707 +/- ##
==========================================
- Coverage 94.08% 93.97% -0.11%
==========================================
Files 32 32
Lines 10061 10081 +20
==========================================
+ Hits 9466 9474 +8
- Misses 425 435 +10
- Partials 170 172 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for index-based access in DQL queries by adding the XGo_Index method and updates the yieldAnyNode logic. My review highlights potential memory issues with the unbounded evalCache and the eager materialization of results in filterNodeSet. Additionally, I have suggested using strconv.ParseInt instead of strconv.Atoi to support non-decimal integer literals consistently.
Add `doc/classfile-resource-spec.md` to define the resource model for XGo classfile frameworks. The specification now defines discovery-based resource introduction over project-scoped pack documents, work classfile-implied top-level resources, and static tool semantics for typed resource references. This also updates `doc/classfile-spec.md` to define `pack` directives, pack roots, and pack documents as the standardized discovery substrate for classfile resource semantics. Fixes goplus#2704 Updates goplus#2719 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
force-pushed
the
dql-eval
branch
3 times, most recently
from
ec75116 to
b60c7e9
Compare
Add `cl/outline/classfile` to load resource schema from one typed framework package. This reader collects resource kinds, discovery directives, name-discovery directives, handle-bearing types, and `resource-api-scope-binding` directives from Go and XGo source. Also fix `outline.NewPackage` to load Go-file constant expressions when reading package outlines. This makes the schema reader work on real Go framework packages such as spx, not just on synthetic test packages. Updates goplus#2704 Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.