[fahimfaisaal]

Summary

Workflow store becomes its own object, found by scope. Queue knows only its scope. Deprecated APIs removed. Stacked on #185.

store := redisq.NewWorkflowStore(qs) ──registers by ScopeID──► contract registry
w.WithQueue(q)                         q: ScopeID() + QueueID() only
task taken  ─► contract.LookupWorkflowStore(scope) ─► store.Runnable / DepResult
task ends   ─► store.FinishTask(queueID, ackID, end)
GET /workflows ─► registered stores + in-memory stores

 // contract v0.8.0
-type WorkflowAcknowledgeable interface { Scoped; WorkflowStore() WorkflowStore; FinishTask(ackID, e) }
 type WorkflowStore interface {
     ...
+    FinishTask(queueID, ackID string, e TaskEnd) (pushed []string, ok bool)
 }
+func RegisterWorkflowStore(s) error   // ErrScopeRegistered, ErrInvalidStore
+func UnregisterWorkflowStore(s); func LookupWorkflowStore(scope) (WorkflowStore, bool); func WorkflowStores() []WorkflowStore

• Durable task with no registered store: not run, not acked (redelivered), error on Errs()/handler once per scope per minute.
• Plain jobs and in-memory tasks unchanged.
• wf: job-ID prefix reserved for workflow tasks: plain Add with such an ID returns false.
• Removed: WithPersistentQueue, WithPersistentPriorityQueue, WithDistributedQueue, WithDistributedPriorityQueue, NewDistributedQueue, NewDistributedPriorityQueue, their handle types, IExternalBaseQueue.NumPending.
• Spec redis-storage.md 1.8.0 (FinishTask is a store operation, §9 entry); openapi 1.5.1 (text only).
• Commits: 5f08515 contract, 03b90a7 removals, d36769b store by scope, b8a17ac review fixes.

Evidence

• go build ./..., go vet ./..., go test -race ./..., cd contract && go test ./...: pass. All example modules vet.
• New tests (appended): store lookup by scope runs + finishes a durable task with right queue/ack ID; no store → not run, not acked, error, runs after registration (single-pop and batch paths, cancel while waiting); /workflows lists registered store; registry errors; reserved wf: IDs; WithQueueCapacity on a durable handle.
• Cross-repo integration with the redisq and sqliteq branches (built with local replaces):
  • sqliteq, folder + single-file: workflow with undo ends compensated.
  • redisq, separate processes: worker without store refuses the task; worker with store completes it; OpenWorkflow finds it.
• Reviewed: per-repo code review, cross-repo contract review, security check; findings fixed in b8a17ac.

Merge Danger

Door: one-way once tagged (contract v0.8.0, varmq v1.11.0 remove API); two-way until then.

Blast Radius: breaking

• Removing deprecated v1 API in a minor release breaks users of those names (user decision).
• Adapters must update: redisq feat/workflow-store-split, sqliteq feat/workflow-store (PRs follow, pinned to contract/v0.8.0).
• Merge docs: sync README, CHANGELOG, spec, examples with main #185 first; then tag contract/v0.8.0 before adapters can pin it.
• Docs site (docs/) not touched: its update follows after this and docs(site): sync docs site with main (WithQueue, cancel, pause, workflows, REST) #186 merge (coverage check pins main).
• CHANGELOG #NN placeholders → this PR's number in a follow-up commit.

[coderabbitai]

Caution

Review failed

The pull request is closed.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

❌ Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
workflow_finish.go	94.44%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!