fix: improve errors - #1088
Open
otjdiepluong wants to merge 1 commit into
Open
fix: improve errors#1088otjdiepluong wants to merge 1 commit into
otjdiepluong wants to merge 1 commit into
Conversation
pull-request-size
Bot
added
the
size/L
caarlos0
reviewed
May 19, 2026
Comment on lines
+1664
to
+1679
| type failAfterNWriter struct { | ||
| n int | ||
| err error | ||
| } | ||
|
|
||
| func (w *failAfterNWriter) Write(p []byte) (int, error) { | ||
| if w.n <= 0 { | ||
| return 0, w.err | ||
| } | ||
| if len(p) > w.n { | ||
| p = p[:w.n] | ||
| } | ||
| w.n -= len(p) | ||
| return len(p), nil | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
we don't really need fail after n bytes on the tests I think?
could be just
type errWriter struct{ err error }
func (e *errWriter) Write([]byte) (int, error) { return 0, e.err }
caarlos0
reviewed
May 19, 2026
caarlos0
left a comment
caarlos0
left a comment
Member
There was a problem hiding this comment.
one comment, looks good otherwise
thanks 🙏🏻
caarlos0
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Notes: