-
Notifications
You must be signed in to change notification settings - Fork 100
Add CTS for texture_and_sampler_let language feature #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jrprice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests LGTM but maybe we should also add some coverage via let in an execution test somewhere (like your textureDimensions change)? Otherwise for Tint we won't hit the part of the compiler that actually needs to do something to handle these things.
I've modified the execution tests for textureDimensions to use a let if supported. |
src/webgpu/shader/validation/expression/call/builtin/textureDimensions.spec.ts
Outdated
Show resolved
Hide resolved
src/webgpu/shader/validation/expression/call/builtin/textureDimensions.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: dan sinclair <[email protected]>
Co-authored-by: dan sinclair <[email protected]>
…mensions.spec.ts Co-authored-by: dan sinclair <[email protected]>
…mensions.spec.ts Co-authored-by: dan sinclair <[email protected]>
CTS for gpuweb/gpuweb#5389
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.