Optimize computation of unrealized checkpoints#678
Open
tushar994 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork choice: skip
process_justification_and_finalizationwhen result is provably unchangedImplements the optimization described in the existing
TODO(Grandine Team)comment infork_choice_store/src/store.rs. Referenced lighthouse for the appropriate change.When computing unrealized checkpoints for a new block in epoch N, if the parent's unrealized justified checkpoint is already at epoch N and its unrealized finalized checkpoint is at epoch N−1, no block in this epoch can push those checkpoints any higher. The child block inherits the parent's values directly and the O(validators)
process_justification_and_finalizationcall is skipped. This fires roughly one third of the time under normal finality conditions.Tests
all tests passed