Add payload present timely store#718
Open
hangleang wants to merge 1 commit into
Open
Conversation
povi
reviewed
Jun 5, 2026
povi
reviewed
Jun 5, 2026
| .unwrap_or(u64::MAX); | ||
| let tick_index = self.tick.kind as u64; | ||
|
|
||
| (tick_index + 1) * BASIS_POINTS <= due_bps * ticks_per_slot |
Collaborator
There was a problem hiding this comment.
We are now not allowing unchecked arithmetics in the app. Please check commit 0de31c0 where this is changed
hangleang
force-pushed
the
feature/add-payload-deadline
branch
from
8a9e8f1 to
339b5bf
Compare
povi
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement ethereum/consensus-specs#5212 and rename PTC payload timely votes predicate function to avoid confusion with the local view.
Close #710