Reintroduce networking spec tests#719
Conversation
SifraiTeam
force-pushed
the
feature/reintroduce-networking-tests
branch
from
4116845 to
91ba5ab
Compare
Tumas
force-pushed
the
feature/reintroduce-networking-tests
branch
2 times, most recently
from
8b06b00 to
91a75dd
Compare
Tumas
force-pushed
the
feature/reintroduce-networking-tests
branch
from
91a75dd to
50329e2
Compare
| Own, | ||
| Persisted, | ||
| Api(Option<Sender<Result<ValidationOutcome>>>), | ||
| Test(GossipId, BlsSetting, StateRootPolicy), |
There was a problem hiding this comment.
Is there a reason why cannot this be under #[cfg(test)]? Then there would be no need to load BlsSetting to prod code and move spec_test_utils from dev-dependencies to dependencies
There was a problem hiding this comment.
Networking tests need a context initialized with pools, the controller, and validator services to mirror the real application, so they live in the validator crate. Running them compiles validator with cfg(test), but workspace dependencies like fork_choice_store (where this message is defined) are compiled without it, so #[cfg(test)] items here are inactive during those tests — see rust-lang/rust#59168. This could likely be worked around with a feature flag, but unclear if it's worth it.
SifraiTeam
force-pushed
the
feature/reintroduce-networking-tests
branch
from
50329e2 to
798075f
Compare
- Re-enable gossip spec tests - Add `AnchorBlock` and `AnchorState` enums for test-specific behaviour - Fix combined Attestation SSZ deserialization
Tumas
force-pushed
the
feature/reintroduce-networking-tests
branch
from
798075f to
4ee2268
Compare
2 participants
AnchorBlockandAnchorStateenums for test-specific behaviour