Avoid full store list materialization in core fallback paths#729
Draft
KrzysztofPajak with Copilot wants to merge 3 commits into
Draft
Avoid full store list materialization in core fallback paths#729KrzysztofPajak with Copilot wants to merge 3 commits into
KrzysztofPajak with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Co-authored-by: KrzysztofPajak <16772986+KrzysztofPajak@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix performance issue of fetching all stores to memory
Avoid full store list materialization in core fallback paths
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IStoreService.GetAllStores()was being used in multiple hot fallback paths that only needed a single store, causing full store collection loading into memory. This change introduces targeted store lookups and rewires key call sites to remove unnecessary full-list fetches.Service API changes
GetFirstStore()toIStoreServicefor single-store fallback retrieval.Grand.stores.firstGrand.stores.host-{host}StoreService query/caching optimization
GetFirstStore()as an ordered single-record query.GetStoreByHost(host)to query by host directly (with per-host cache), instead of loading all stores then filtering in memory.Skip(1).Any()) rather than loading all stores.High-impact call-site rewiring
GetAllStores().FirstOrDefault()fallbacks withGetFirstStore()in:Example (pattern change)