Skip to content

Fix storefront rendering with no CSS/JS (Razor tag helper regression) #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrzysztofPajak merged 3 commits into from
Aug 14, 2026
Merged

Fix storefront rendering with no CSS/JS (Razor tag helper regression) #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac1b7aa
Fix plugin tag helper discovery broken by ExcludeAssets=all
KrzysztofPajak Aug 14, 2026
5dcd2d9
Pin .NET SDK to 10.0.301 to avoid a Razor tag helper regression
KrzysztofPajak Aug 14, 2026
1d222a7
Pin CI to .NET SDK 10.0.301, matching global.json/Dockerfile
KrzysztofPajak Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/aspnetcore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v4
with:
dotnet-version: 10.0.x
dotnet-version: 10.0.301
- name: Restore
run: dotnet restore ./GrandNode.sln
- name: Build with dotnet
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v4
with:
dotnet-version: 10.0.x
dotnet-version: 10.0.301
- name: Cache SonarQube Cloud packages
uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ jobs:
- name: Setup .NET 10 SDK
uses: actions/setup-dotnet@v3
with:
dotnet-version: '10.0.x'
dotnet-version: '10.0.301'
2 changes: 1 addition & 1 deletion .github/workflows/grandnode.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v4
with:
dotnet-version: 10.0.x
dotnet-version: 10.0.301
- name: Create mongoDB Docker container
run: sudo docker run -d -p 27017:27017 mongo:latest
- name: Wait for MongoDB to be ready
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build stage
FROM mcr.microsoft.com/dotnet/sdk:10.0 AS build-env
FROM mcr.microsoft.com/dotnet/sdk:10.0.301 AS build-env
LABEL stage=build-env
WORKDIR /app

Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ steps:
- task: UseDotNet@2
displayName: 'Install .NET Core SDK 10'
inputs:
version: '10.0.x'
version: '10.0.301'

# Replaced NuGet tasks with dotnet CLI commands to fix Ubuntu 24.04 compatibility
- task: DotNetCoreCLI@2
Expand Down
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "10.0.100",
"rollForward": "latestFeature"
"version": "10.0.301",
"rollForward": "latestPatch"
}
}
4 changes: 2 additions & 2 deletions src/Build/Grand.Plugin.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
<ProjectReference Include="$(MSBuildThisFileDirectory)..\Core\Grand.Mediator\Grand.Mediator.csproj" Private="false" ExcludeAssets="runtime" />
<ProjectReference Include="$(MSBuildThisFileDirectory)..\Core\Grand.Infrastructure\Grand.Infrastructure.csproj" Private="false" ExcludeAssets="runtime" />
<ProjectReference Include="$(MSBuildThisFileDirectory)..\Business\Grand.Business.Core\Grand.Business.Core.csproj" Private="false" ExcludeAssets="runtime" />
<!-- ExcludeAssets=all: referenced for its views and tag helpers, nothing is linked from it -->
<ProjectReference Include="$(MSBuildThisFileDirectory)..\Web\Grand.Web.Common\Grand.Web.Common.csproj" Private="false" ExcludeAssets="all" />
<!-- ExcludeAssets=runtime: referenced for its views and tag helpers, nothing is linked from it -->
<ProjectReference Include="$(MSBuildThisFileDirectory)..\Web\Grand.Web.Common\Grand.Web.Common.csproj" Private="false" ExcludeAssets="runtime" />
</ItemGroup>

</Project>
Loading