test: pin row identity, path order, and reached label collisions - #199
Merged
Conversation
|
Automated tck-gfql conformance summary for this PR.
Unified Conformance SummaryHeadline Counts
Manifest Summary
Direct-Cypher Delta
Debt Movement
Direct-Cypher Added Passing CasesNone. Direct-Cypher Added Expected-Error CasesNone. Direct-Cypher Removed CasesNone. Direct-Cypher Changed CasesNone. Newly Broken Support ClassificationsNone. Recovered DebtNone. Removed Debt CasesNone. Input Warnings
|
lmeyerov
marked this pull request as ready for review
September 13, 2026 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structured GFQL must preserve entity identity, exact identifiers, physical node rows, and path order across optimized and generic execution. These regressions caught alias properties restored from the wrong entity, nullable integer IDs losing precision, reordered paths, dropped duplicate/null node rows, and HAS-label collisions filtered in the wrong order.
Add 240 regression cases across pandas, native Polars, and optional cuDF, with normal and disabled fast routes:
Exact merged-master conformance passed against pygraphistry
2ca98922cd9ce05a16c74acd5e119232904b4377: 4,329 passed, 86 skipped, 689 expected failures in each normal/all-nine-off mode. Logs verify the exact source and all nine disabled routes. Hosted optional-backend skips do not establish GPU execution.All 240 added regressions passed locally with pandas, Polars, and actual cuDF enabled on the isolated integration tree
19cc89edf125172978aff79b2fe5aba249cf5079. The actual master merge has that identical tree. This is source-tree equivalence evidence; the full merged-master DGX run remains separately tracked.The dependency pygraphistry PR2072 is now merged. Ordinary CI pinned to merged master passed: 4,243 passed, 172 skipped, 689 expected failures, plus one setup check. Merged-master product CI passed: 83 successful jobs, two PR-only jobs skipped, and zero divergences in all ten route modes. The original PR check was rerun after the product merge and now also passes against the exact merged-master revision. Earlier failure reproducers remain retained. TCK issue200 concerns separate whole-entity projection metadata and remains colleague-owned.