Skip to content

fix(tck): distinguish whole entities using projection provenance - #201

Merged
lmeyerov merged 3 commits into
mainfrom
fix/gfql-entity-projection-provenance
Sep 14, 2026
Merged

lmeyerov merged 3 commits into
mainfrom
fix/gfql-entity-projection-provenance

Conversation

@lmeyerov

@lmeyerov lmeyerov commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

The TCK adapter now consumes explicit entity kind and presence metadata so unlabeled whole-entity returns remain distinct from property/scalar projections and absent OPTIONAL rows. It preserves the distinction between unrecorded provenance and explicitly empty metadata, with compatibility controls for older product behavior and unchanged result oracles.

Merged as 84b098c2784849a47e1c3c12bbf0766a2ffe3b4b, after product #2079 merged as 65c359b5d94231224010ce00f7bcbbfadcb1e4fb. Issue #200 is closed.

The increased default-CI skips include176opt-in Polars/cuDF variants of88new upstream cases. The nativePolars run covers the Polars variants;88cuDF variants remain opt-in and were not executed by these CPU workflows. Separate product-level #2079 tests exercised pandas, Polars, cuDF25/26 and PolarsGPU26, including56focused entity cases passing in the GPU image. Device/TCK scope is disclosed rather than treating skips or backend declines as execution passes.

The merged product's graphistry tree exactly matches the combined source used for device and integration testing. Full evidence and residual baseline compatibility debt are tracked in graphistry/pygraphistry#2074 and #2082.

@github-actions

Copy link
Copy Markdown

Automated tck-gfql conformance summary for this PR.

  • Base: main
  • Head: fix/gfql-entity-projection-provenance
  • Structured artifact: unified-conformance-summary
  • Direct-Cypher delta: no added, removed, or changed cases.

Unified Conformance Summary

Headline Counts

metric value
Scenarios total 3658
Supported 2964
Xfail 689
Skip 5
GFQL translated 2936
Direct-Cypher total snapshot 2921
Direct-Cypher promoted-only rows 819
Direct-Cypher promoted-only expected errors 142
Direct-Cypher non-validation debt 0

Manifest Summary

metric value
Manifest scenario entries 3658
Manifest supported 2964
Manifest xfail 689
Manifest skip 5
Manifest translated 2936
Manifest direct-Cypher only 276
Manifest not yet implemented 446
Manifest direct-Cypher debt keys 0

Direct-Cypher Delta

category count
Added passing cases 0
Added expected-error cases 0
Removed cases 0
Changed cases 0
Remaining debt 0

Debt Movement

category count
Newly broken support classifications 0
Recovered debt transitions 0
Removed debt cases 0
Remaining direct-Cypher debt 0

Direct-Cypher Added Passing Cases

None.

Direct-Cypher Added Expected-Error Cases

None.

Direct-Cypher Removed Cases

None.

Direct-Cypher Changed Cases

None.

Newly Broken Support Classifications

None.

Recovered Debt

None.

Removed Debt Cases

None.

Input Warnings

  • old artifact has no direct_cypher_cases inventory; case-level pass/error deltas are limited to fields present in the artifact.
  • new artifact has no direct_cypher_cases inventory; case-level pass/error deltas are limited to fields present in the artifact.

@github-actions

Copy link
Copy Markdown

Automated pygraphistry GFQL coverage-gap delta for this PR.

  • Baseline: post-#1609 coverage-gap report
  • Base: pygraphistry merge-base 24233cb701e4757d9d6d71c9c0394ce9d4393351
  • Head: fix/gfql-entity-projection-provenance
  • Structured artifact: coverage-gap-pr-delta

Evidence-only pygraphistry GFQL coverage delta for shrink PR review.

  • Baseline: post-#1609 coverage-gap report
  • Base: pygraphistry merge-base 24233cb701e4757d9d6d71c9c0394ce9d4393351
  • Head: fix/gfql-entity-projection-provenance
  • Touched priority files: 1
  • Newly-uncovered executable lines: 376
  • Newly-covered executable lines: 374

Priority File Deltas

File Status Coverage delta Newly-uncovered lines Newly-covered lines
graphistry/compute/gfql_unified.py compared +0.04 pp 110, 134-135, 160-161, 168-169, 188, 196, 209, 228, +188 more 106, 118, 157-158, 166-167, 186, 194, 207, 226, +186 more
This comment is coverage evidence only; shrink decisions remain with pygraphistry owners.

@lmeyerov
lmeyerov marked this pull request as ready for review September 13, 2026 01:33
@lmeyerov
lmeyerov merged commit 84b098c into main Sep 14, 2026
8 of 9 checks passed
@lmeyerov
lmeyerov deleted the fix/gfql-entity-projection-provenance branch September 14, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant