Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/remove-graphiql-laboratory.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'hive': minor
---

Remove the GraphiQL laboratory tab. The Hive Laboratory is now the only laboratory: it runs the same preflight scripts with a compatible runtime, and on a user's first visit it carries over their GraphiQL environment variables and preflight toggle before clearing the GraphiQL-era browser storage. GraphiQL's own unsaved tabs and run history are not carried over; collections, operations and preflight scripts are stored server-side and are unaffected. The development-only `/dev` GraphiQL page is removed as well.
2 changes: 0 additions & 2 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ module.exports = {
'ring-offset-.*',
// Data attribute variants with custom animations (for Radix UI components)
'data-\\[side=(top|right|bottom|left)\\]:animate-slide-(up|down|left|right)-fade',
// GraphiQL classes
'graphiql-.*',
// hive classes
'hive-.*',
// Schema diff custom classes (defined in index.css)
Expand Down
4 changes: 0 additions & 4 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ updates:
schedule:
interval: 'daily'
groups:
graphiql:
patterns:
- 'graphiql'
- '@graphiql/*'
yoga:
patterns:
- 'envelop'
Expand Down
3 changes: 0 additions & 3 deletions e2e/helpers/laboratory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,6 @@ export function createLaboratoryHelper(page: Page): LaboratoryHelper {

const helper: LaboratoryHelper = {
async openSeededTarget(slug, search = '') {
await page.addInitScript(() => {
window.localStorage.setItem('hive:laboratory:welcome-dialog-shown', 'true');
});
await page.goto(`/${slug}/laboratory${search}`, { waitUntil: 'domcontentloaded' });
await expect(page.locator('.hive-laboratory-host')).toBeVisible({ timeout: 30_000 });
},
Expand Down
2 changes: 2 additions & 0 deletions e2e/specs/laboratory-preflight.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,12 @@ test.describe('Laboratory > Preflight', () => {
test('carries the GraphiQL env and toggle over on first visit', async ({ page, laboratory }) => {
await project.updatePreflightScript({ sourceCode: `console.log('legacy');` });
await page.addInitScript(() => {
window.localStorage.setItem('hive:laboratory:type', 'graphiql');
window.localStorage.setItem('hive:laboratory:environment', '{"foo":"bar","count":2}');
window.localStorage.setItem('hive:laboratory:isPreflightScriptEnabled', 'true');
});
await openWithOperation(laboratory);
expect(await page.evaluate(() => localStorage.getItem('hive:laboratory:type'))).toBeNull();

await expect(page.getByRole('button', { name: 'Disable preflight' })).toBeVisible();
await laboratory.openEnvTab();
Expand Down
2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@
"@apollo/federation@0.38.1": "patches/@apollo__federation@0.38.1.patch",
"got@16.1.0": "patches/got@16.1.0.patch",
"oclif@4.22.65": "patches/oclif@4.22.65.patch",
"graphiql@4.0.0-alpha.5": "patches/graphiql@4.0.0-alpha.5.patch",
"@graphiql/react@1.0.0-alpha.4": "patches/@graphiql__react@1.0.0-alpha.4.patch",
"@slonik/pg-driver@48.19.0": "patches/@slonik__pg-driver@48.19.0.patch",
"@whatwg-node/fetch@0.12.1": "patches/@whatwg-node__fetch@0.12.1.patch",
"@graphql-tools/executor@1.5.0": "patches/@graphql-tools__executor@1.5.0.patch"
Expand Down
2 changes: 1 addition & 1 deletion packages/web/app/docs/DATA.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ src/routes/target/alerts.tsx the gate; activity: default range, loa
src/routes/target/apps.tsx loaderDeps on the sort, and on the settled search term; warm beside the gate
src/routes/target/proposals.tsx the gate; list and proposal warm + revalidate beside it, loaderDeps on the
stage filter and on version + ts
src/routes/target/laboratory.tsx the gate alone
src/routes/target/laboratory.ts the gate alone
src/lib/testing/urql.ts createTestClient on cacheOptions; fixtures/ and mocks/ beside it
```

Expand Down
2 changes: 1 addition & 1 deletion packages/web/app/docs/ROUTER.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ src/routes/
tree.ts root.addChildren([...]) mirroring every route's getParentRoute
root.tsx root route, 404, logout, join
anonymous.tsx /auth/* (pathless `anonymous` parent)
authenticated.tsx /, /dev, /manage, /org/new, transfer (pathless `authenticated` parent: the session gate)
authenticated.tsx /, /manage, /org/new, transfer (pathless `authenticated` parent: the session gate)
with-header.tsx the header, once, above the routes below (pathless `with-header` parent)
oidc-request.tsx $organizationSlug/oidc-request, the OIDC interstitial
organization/route.tsx $organizationSlug layout + index, support, subscription
Expand Down
7 changes: 0 additions & 7 deletions packages/web/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
"@fastify/static": "10.1.5",
"@fastify/vite": "9.2.0",
"@fontsource-variable/instrument-sans": "5.3.0",
"@graphiql/plugin-explorer": "4.0.0-alpha.2",
"@graphiql/react": "1.0.0-alpha.4",
"@graphiql/toolkit": "0.9.1",
"@graphql-hive/laboratory": "workspace:*",
"@graphql-inspector/core": "8.0.0",
"@graphql-inspector/patch": "catalog:",
Expand All @@ -29,7 +26,6 @@
"@hookform/resolvers": "5.9.1",
"@monaco-editor/react": "catalog:",
"@pierre/diffs": "1.5.1",
"@repeaterjs/repeater": "3.1.0",
"@sentry/node": "catalog:",
"@sentry/react": "11.9.0",
"@sentry/vite-plugin": "11.9.0",
Expand All @@ -44,7 +40,6 @@
"@tanstack/react-virtual": "3.14.13",
"@testing-library/dom": "10.4.2",
"@testing-library/react": "16.3.3",
"@types/crypto-js": "4.2.2",
"@types/js-cookie": "3.0.6",
"@types/lodash.debounce": "4.0.9",
"@types/react": "catalog:",
Expand All @@ -55,7 +50,6 @@
"@vitejs/plugin-react": "catalog:",
"class-variance-authority": "0.7.1",
"clsx": "2.1.1",
"crypto-js": "catalog:",
"date-fns": "catalog:",
"date-fns-tz": "3.2.0",
"diff": "9.0.0",
Expand All @@ -64,7 +58,6 @@
"echarts": "6.1.0",
"esbuild": "catalog:",
"fastify": "catalog:",
"graphiql": "4.0.0-alpha.5",
"graphql": "catalog:",
"graphql-sse": "catalog:",
"idb-keyval": "6.3.0",
Expand Down
13 changes: 0 additions & 13 deletions packages/web/app/preflight-worker-embed.html

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading