Skip to content

polish(validateInputValue): cover invalid values in iterable input #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vrana055 wants to merge 1 commit into
base: 17.x.x
Choose a base branch
from
Open

polish(validateInputValue): cover invalid values in iterable input #4845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/utilities/__tests__/validateInputValue-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,6 @@ describe('validateInputValue', () => {
});

it('returns no error for a valid iterable input', () => {
// TODO: put an error in this list and show it appears
function* listGenerator() {
yield 1;
yield 2;
Expand All @@ -507,6 +506,26 @@ describe('validateInputValue', () => {
test(listGenerator(), TestList, []);
});

it('returns an error for an invalid iterable input', () => {
function* listGenerator() {
yield 1;
yield 'b';
yield true;
yield 4;
}

test(listGenerator(), TestList, [
{
error: 'Int cannot represent non-integer value: "b"',
path: [1],
},
{
error: 'Int cannot represent non-integer value: true',
path: [2],
},
]);
});

it('returns an error for an invalid input', () => {
test([1, 'b', true, 4], TestList, [
{
Expand Down