Skip to content

feat(RelativeRangeDatePicker): allow null values in relative range presets#188

Merged
ValeraS merged 8 commits intomainfrom
feat/issue-186/add-null-values-option-to-relative-range-preset
Mar 16, 2026
Merged

feat(RelativeRangeDatePicker): allow null values in relative range presets#188
ValeraS merged 8 commits intomainfrom
feat/issue-186/add-null-values-option-to-relative-range-preset

Conversation

@SkiffCMC
Copy link
Contributor

I hereby agree to the terms of the CLA available at: [https://yandex.ru/legal/cla/?lang=en]

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

Comment on lines +36 to +37
start?: string | null,
end?: string | null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
start?: string | null,
end?: string | null,
start: string | null,
end: string | null,

@ValeraS ValeraS force-pushed the feat/issue-186/add-null-values-option-to-relative-range-preset branch from 0807e6a to 4783fdd Compare March 15, 2026 18:10
@github-actions
Copy link

github-actions bot commented Mar 15, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 66.01% 1725 / 2613
🔵 Statements 66.19% 1760 / 2659
🔵 Functions 70.4% 345 / 490
🔵 Branches 60.57% 1418 / 2341
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/RelativeDatePicker/RelativeDatePicker.tsx 94.11% 62.85% 100% 94.11% 161
src/components/RelativeRangeDatePicker/utils.ts 70% 65.45% 40% 70% 11-28, 99-103
src/components/RelativeRangeDatePicker/components/Control/Control.tsx 100% 66.66% 100% 100%
src/components/RelativeRangeDatePicker/components/PickerDialog/PickerDoc.tsx 75.86% 61.53% 75% 75.86% 67, 144-157, 177, 181
src/components/RelativeRangeDatePicker/components/PickerDialog/PickerForm.tsx 70.96% 60.78% 60% 70.96% 75, 116-163
src/components/RelativeRangeDatePicker/components/PickerDialog/useRelativeRangeDatePickerDialogState.tsx 62.96% 50% 77.77% 62.96% 42, 55, 67-89, 95, 108-111, 166
src/components/RelativeRangeDatePicker/components/Presets/Presets.tsx 89.18% 60% 100% 88.57% 48, 53, 57, 119
src/components/RelativeRangeDatePicker/components/Presets/defaultPresets.tsx 100% 100% 100% 100%
src/components/RelativeRangeDatePicker/components/Presets/utils.ts 47.05% 56.6% 71.42% 47.05% 51-73, 92, 96, 120-147
Generated in workflow #76 for commit d859b80 by the Vitest Coverage Report Action

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Mar 15, 2026

🎭 Tests Report is ready.
🎭 Coverage Report is ready.

@ValeraS ValeraS self-requested a review March 15, 2026 18:12
@ValeraS ValeraS force-pushed the feat/issue-186/add-null-values-option-to-relative-range-preset branch from 4783fdd to d859b80 Compare March 15, 2026 18:47
@ValeraS ValeraS merged commit 405da9e into main Mar 16, 2026
4 checks passed
@ValeraS ValeraS deleted the feat/issue-186/add-null-values-option-to-relative-range-preset branch March 16, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants