Skip to content

Multiple Makefile fixes: - #58

Open
mgorny wants to merge 3 commits into
graysky2:masterfrom
mgorny:fix-makefile
Open

Multiple Makefile fixes:#58
mgorny wants to merge 3 commits into
graysky2:masterfrom
mgorny:fix-makefile

Conversation

@mgorny

@mgorny mgorny commented Aug 3, 2019

Copy link
Copy Markdown
  1. Stop compressing manpage implicitly.
  2. Use explicit dependencies for install-bin target.
  3. Fix install(1) usage to be portable to non-GNU systems.

mgorny added 3 commits August 3, 2019 09:01
Manpage compression is a packager/sysadmin task.  Forcing .gz
compression via Makefile not only creates duplicate work but is also
frequently wrong (modern distros use different compressed file formats).
Rather than opaquely making 'install' depend on 'all' (and 'install-bin'
fail when called immediately), make 'install-bin' specifically depend
on the generated binary file it needs.
'install -D' option is specific to GNU userland, and does not work
anywhere else.  Use explicit 'install -d' to create files prior to
installing them.
@CrafterSvK

Copy link
Copy Markdown

Non-gnu systems have also problem with bash. The code itself should be posix complaint or work on dash.

@graysky2
graysky2 force-pushed the master branch 2 times, most recently from 6242df0 to 4115a1c Compare September 12, 2019 19:27
@mgorny

mgorny commented Nov 11, 2019

Copy link
Copy Markdown
Author

Ping.

@graysky2
graysky2 force-pushed the master branch 3 times, most recently from bb1dbd9 to 1eb2a0c Compare May 9, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants