Only generate report if detailedReport option is set - #28
Open
adamduncan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior
Generate report if
process.env.NODE_ENV === 'production'Proposed behavior
As well as checking
NODE_ENV, we leverage Parcel'sdetailedReportoption to determine whether to generate a report.This is opposite of the plugin's existing behaviour, but affords the user control of when to generate reports, without modifying existing Parcel functionality.
Conscious this would be a breaking change, but wanted to float it, given #14.
If the plugin's considering further development (or this is worth exploring), happy to write the tests, update docs, etc.