Skip to content

Add Washington DC Provider#760

Closed
liamnorm wants to merge 4 commits into
grote:masterfrom
liamnorm:master
Closed

Add Washington DC Provider#760
liamnorm wants to merge 4 commits into
grote:masterfrom
liamnorm:master

Conversation

@liamnorm

@liamnorm liamnorm commented Jun 3, 2021

Copy link
Copy Markdown

Adds support for Washington, DC using the "us-dc" location from Navitia.

@cla-bot

cla-bot Bot commented Jun 3, 2021

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @liamnorm on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot

@ialokim ialokim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good overall.

Comment thread app/witness.gradle
'com.android.tools.analytics-library:shared:27.1.3:shared-27.1.3.jar:10d2a51d8f89ff4ac849888e5a9c60b10e879c30d78545ec1da4d3df7bd56ae4',
'com.android.tools.analytics-library:tracker:27.1.3:tracker-27.1.3.jar:589b355a2ba796cbc0a2b2295737de6661f078262e5f87cd6f540b8d011e5ebb',
'com.android.tools.build:aapt2-proto:4.1.0-alpha01-6193524:aapt2-proto-4.1.0-alpha01-6193524.jar:17e75523e1e92dd4f222c7368ee41df9e964a508232f591e265d0c499baf9dca',
'com.android.tools.build:aapt2:4.1.3-6503028:aapt2-4.1.3-6503028-osx.jar:6c57e78049706e57ff65ad8c5fef43ed840c086710aeafa701953d6abbc90724',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is problematic as it is platform-dependent. Will have to remove that before merging. If #759 gets merged first, that should be no problem.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency needed?

Comment thread app/src/main/res/values/strings.xml Outdated
@liamnorm

liamnorm commented Jun 4, 2021

Copy link
Copy Markdown
Author

I accept the Contributor License Agreement.

Repository owner deleted a comment from cla-bot Bot Jun 4, 2021
Repository owner deleted a comment from cla-bot Bot Jun 4, 2021
Repository owner deleted a comment from cla-bot Bot Jun 4, 2021
@liamnorm liamnorm requested a review from ialokim June 21, 2021 19:52
@ialokim

ialokim commented Aug 13, 2023

Copy link
Copy Markdown
Collaborator

See #801 . Navitia unfortunately stopped serving the data for that region.

@ialokim ialokim closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants