Open
Conversation
… SPI speed and video now correctly assembles 4 segment image from Lepton 3.
Member
|
Thanks for the updates! This looks pretty good to me from a code review perspective. My only gripe is that the default SPI CS for this application has changed from 0 to 1, so that will break people who swap out their L2 for an L3 on the same system. However there is now better plumbing in place to address it properly. What do others think about this? Also, any suggestions on if/how we should maintain backwards compatibility with L2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote the code in LeptonThread.cpp to accommodate a slower SPI speed (20MHz). Switched from simply using an array to store the read to using segmented structs. An image is created from four segments, which hold 60 packets of data each. Each packet is a 164 byte line from SPI. This version reads 20 packets into a frame buffer at a time, which is as close to the 4096 byte limit as we could go. The Lepton runs just as well as before, with very few dropped frames.
Andrew Myers
Novacoast, Inc.
[email protected]