xds-client: add canonical xdstp resource-name parsing - #2814
Draft
W4lspirit wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gRFC A47 identifies federated xDS resources with
xdstp://URIs. These names need stable equality and hashing across percent-encoding and context-parameter order, while their opaque paths must not be changed.I'm not using the
urlcrate as it will normalizing the path:This parsing foundation is kept separate from authority routing so it can be reviewed and merged without changing the behavior of existing non-federation clients.
What changed
ResourceNameandAuthorityKeyfor legacy andxdstpresource names.xdstp:scheme.Compatibility
This PR does not connect the parser to watch routing, bootstrap authorities, or server selection. Legacy resource names round-trip byte-for-byte, and the existing single-server path is unchanged.
Validation
cargo test -p xds-clientcargo clippy -p xds-client --all-targets -- -D warningsPart of #2795.