grpc-protobuf: disable grpc default features - #2816
Merged
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
grpc-protobufcrate depends ongrpcwithout disabling default features.I don't want to bring the entire Hickory Resolver into my project since i don't even need DNS resolution, so i add grpc as
--no-default-features -F _runtime-tokio.But then i add grpc-protobuf, and Hickory's dependency tree appears again, because it requires the default features of grpc including
dns, which i specifically wanted to opt-out from.Solution
Set
default_features = falsefor grpc dependency in grpc-protobuf, so this utility crate doesn't opt-in for possibly undesired grpc crate features.By the way, the same thing is already done in grpc-google (though i don't know if the reason was the same):
grpc-rust/grpc-google/Cargo.toml
Line 17 in 38c7e61