Repository navigation
test: drive the profile import on the real create-project card - #321
Merged
Merged
Conversation
Refs #297 The unit tests hold the resolver, and #308 fixed the card. What neither can show is the path the operator takes: pick a file, read the summary, press Create, and be left with exactly what the summary said, then close the project, open it again and still have it. e2e/profile-import.spec.ts runs the built app with a temp HOME. Only the native file picker is replaced (dialog.showOpenDialog answers with a fixture path); the IPC, the file read, the card, project.create and the config read back from disk are the shipped code. It covers A then B, B then A and the same file twice, a warning-off profile on its own, exclusions with no scope, an explicitly empty list, YAML, clearing, each refused-file case leaving the earlier import untouched, and backing out of the picker. A project closed and reopened holds what was created. Checked against the two original defects: putting back "pass the config only when a list has entries" fails the warn-off test, and layering the new import over the old fails the A-then-B test. Both reverted. Not exercised: the native picker itself. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Under xvfb a fresh Electron window yields no animation frames until something wakes it, and Playwright's click waits for two stable frames, so the spec timed out on its first click on ubuntu CI while passing on Windows. page.bringToFront() restores frames; reproduced and verified in WSL under xvfb-run. Refs #297 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…oFront bringToFront did not hold: with it the spec still timed out on its first click under xvfb. A reload restores animation frames, and is what the other specs that click after launch already do. Verified in WSL under xvfb-run. Refs #297 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #297
What
The resolver has unit tests and #308 fixed the card, but nothing drove the path the operator takes: pick a file, read the summary, press Create, and be left with what the summary said.
e2e/profile-import.spec.tsdoes that on the built app with a temp HOME.Only the native file picker is replaced (
dialog.showOpenDialoganswers with a fixture path). The IPC, the file read, the React card,project.createand the config read back from disk are the shipped code.Covered (8 tests)
warnOnViolation: falseis saved as false.Checked against the original defects
initialConfigonly when a list has entries" fails the warn-off test (Expected: false, Received: true).範圍 1 · 排除 1).Both were reverted; the spec is green on the clean build.
Not covered
Gates
typecheck,
verify:specs,verify:architectureandverify:i18nare green.npm testhad one failure,test/zsh-divert-missing-pts.test.ts, a WSL-backed test this branch does not touch: it timed out at 90 s under the full-suite load and passed on its own in 20 s, the shape CLAUDE.md documents as the known flake.🤖 Generated with Claude Code